Skip to content

Conversation

@bdunne
Copy link
Member

@bdunne bdunne commented Aug 28, 2018

Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gtanzillo gtanzillo self-assigned this Aug 28, 2018
Copy link
Contributor

@Ladas Ladas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@miq-bot
Copy link
Member

miq-bot commented Sep 4, 2018

This pull request is not mergeable. Please rebase and repush.

@bdunne bdunne force-pushed the product_features_for_servicey_things branch from 3a9daf1 to 822642f Compare September 6, 2018 15:21
@miq-bot
Copy link
Member

miq-bot commented Sep 6, 2018

Checked commits bdunne/manageiq@e7a33db~...822642f with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@gtanzillo gtanzillo added this to the Sprint 94 Ending Sept 10, 2018 milestone Sep 10, 2018
@gtanzillo gtanzillo merged commit e7863d1 into ManageIQ:master Sep 10, 2018
@bdunne bdunne deleted the product_features_for_servicey_things branch September 10, 2018 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants