Move afterEach after the before and/or to the higher context #9658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrafanie
force-pushed
the
cypress_after_each_cleanup
branch
from
ac16701 to
746bd1b
Compare
Fryguy
approved these changes
Oct 14, 2025
jrafanie
added a commit
to jrafanie/manageiq-ui-classic
that referenced
this pull request
Oct 15, 2025
Fixes ManageIQ#9658's overzealous grouping of common setup/teardown in describe blocks even though some tests didn't have that setup previously.
jrafanie
added a commit
to jrafanie/manageiq-ui-classic
that referenced
this pull request
Oct 23, 2025
This commit reverts ManageIQ#9660, ManageIQ#9658 and part of ManageIQ#9633. The database reset in the tenant spec is colliding with another puma thread that is trying to do an API request at the same time. We need to ensure the reset is done in isolation to avoid this test failure that is happening more than sporadically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #9633