Fix the tag mapping form #9612
Merged
Fix the tag mapping form #9612
+40
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elsamaryv
reviewed
Sep 11, 2025
GilbertCherrie
force-pushed
the
fix_settings_mapping_form
branch
from
63efd10 to
a7bc92b
Compare
|
@elsamaryv can you please review and test again |
elsamaryv
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the tag mapping form.
Before:
Clicking the Add Mapping Rule button or a row in the table does nothing and throws an error.
After:
Clicking the Add Mapping Rule button now redirects to the add form.
Clicking a row on the table now redirects to the edit form.
Fix default form values so the form doesn't error on first submit.
