show zone collect logs

[MelsHyrule]

Fixes #8135

Before

After

@miq-bot add-reviewer @kavyanekkalapu
@miq-bot assign @kavyanekkalapu

[Fryguy]

Oh I missed it in the screenshot...it's undefined method .started? for Zone. In that case we shouldn't catch an exception but should check for that explicitly. So I'm thinking we this should check the @selected_server is actually a server, or perhaps check if it responds_to?(:started?) (perhaps with try).

I'm also curious why @selected_server is a zone object. that seems weird to me...did something change in the controller?

[chessbyte]

@Fryguy Since log collection does not work in Podified (users should use EFK) and it is not a core function of the product (but only assists in diagnostics), should it be added to the Chopping Block?

[Fryguy]

@chessbyte maybe not chopping block completely, but we should definitely discuss as it probably needs to be rethought. Users still need to get the logs somehow, but maybe a UI thing isn't the right way anymore. I still like the central logging idea we were going to do with journald remote on appliances.

[miq-bot]

Checked commit MelsHyrule@2888e15 with ruby 2.6.7, rubocop 1.19.1, haml-lint 0.35.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 🍰

[MelsHyrule]

why @selected_server is a zone object.

@Fryguy @selecter_server always had the case for being a Zone object you can find it here https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/controllers/ops_controller/diagnostics.rb#L600

[Fryguy]

Wild. Thanks for tracking that down.

[Fryguy]

Backported to najdorf in commit bf777fc.

commit bf777fce809261607ea9d53373d419fc8cdb70fd
Author: Kavya Nekkalapu <[email protected]>
Date:   Mon Feb 28 14:14:25 2022 -0500

    Merge pull request #8140 from MelsHyrule/show_zone_collect_logs
    
    show zone collect logs
    
    (cherry picked from commit 439a5d33db1dcf1d090f7bef6e651c107951b5b2)