Skip to content

Conversation

@Ladas
Copy link
Contributor

@Ladas Ladas commented Aug 23, 2018

Specs for the new refresh projects, pods and the service catalog entities

Depends on:

@Ladas
Copy link
Contributor Author

Ladas commented Aug 23, 2018

cc @gtanzillo

@cben
Copy link
Contributor

cben commented Aug 23, 2018

Yay tests 😸

  1. please document, what does it take to re-record this cassette.
    ideally, extend the test_objects_record.sh script we use for the main refresh cassettes.
    see https://github.com/ManageIQ/guides/blob/master/providers/openshift.md#automated-script-to-record-new-vcr

  2. do we need both this and refresher_spec.rb ?
    it's hard to see what are the differences between the 2 modes.
    and I think if we have multiple refresh modes, testing them all on same data is a stronger test than separate data & assertions, because it'd prove equivalence.

Honestly, I've lost track of what is duplicated now and what you plan to converge/drop...

@Ladas
Copy link
Contributor Author

Ladas commented Aug 27, 2018

@cben right, it's just our shared env, so it's a random data. I'll try to setup the VCR script for it. For now we'll have at least some specs.

For the new vs. old refresh. I am not sure, for now, we will focus just on entities needed by the Service Catalog and we'll expand it as needed. Right @agrare ?

@Ladas Ladas force-pushed the refresh_service_catalog_entities branch from f99e266 to bbb855f Compare August 27, 2018 12:57
@miq-bot
Copy link
Member

miq-bot commented Aug 27, 2018

Some comments on commits Ladas/manageiq-providers-openshift@4caf5fa~...bbb855f

spec/vcr_cassettes/manageiq/providers/openshift/container_manager/refresher_inventory_object.yml

  • 💣 💥 🔥 🚒 - 105 - Detected cfme
  • 💣 💥 🔥 🚒 - 105 - Detected cloudforms
  • 💣 💥 🔥 🚒 - 106 - Detected cfme
  • 💣 💥 🔥 🚒 - 106 - Detected cloudforms
  • 💣 💥 🔥 🚒 - 108 - Detected cfme
  • 💣 💥 🔥 🚒 - 108 - Detected cloudforms
  • 💣 💥 🔥 🚒 - 111 - Detected cloudforms
  • 💣 💥 🔥 🚒 - 112 - Detected cloudforms
  • 💣 💥 🔥 🚒 - 114 - Detected cloudforms
  • 💣 💥 🔥 🚒 - 115 - Detected cloudforms
  • 💣 💥 🔥 🚒 - 116 - Detected cloudforms
  • 💣 💥 🔥 🚒 - 117 - Detected cloudforms
  • 💣 💥 🔥 🚒 - 119 - Detected cloudforms
  • 💣 💥 🔥 🚒 - 121 - Detected cfme
  • 💣 💥 🔥 🚒 - 121 - Detected cloudforms
  • 💣 💥 🔥 🚒 - 122 - Detected cfme
  • 💣 💥 🔥 🚒 - 122 - Detected cloudforms
  • 💣 💥 🔥 🚒 - 124 - Detected cfme
  • 💣 💥 🔥 🚒 - 124 - Detected cloudforms
  • 💣 💥 🔥 🚒 - 68 - Detected cfme
  • 💣 💥 🔥 🚒 - 69 - Detected cloudforms
  • 💣 💥 🔥 🚒 - 8952 - Detected cfme
  • 💣 💥 🔥 🚒 - 8952 - Detected cloudforms
  • 💣 💥 🔥 🚒 - 8953 - Detected cfme
  • 💣 💥 🔥 🚒 - 8953 - Detected cloudforms
  • 💣 💥 🔥 🚒 - 9040 - Detected cloudforms
  • 💣 💥 🔥 🚒 - 9041 - Detected cfme
  • 💣 💥 🔥 🚒 - 9041 - Detected cloudforms
  • 💣 💥 🔥 🚒 - 9042 - Detected cfme
  • 💣 💥 🔥 🚒 - 9042 - Detected cloudforms
  • 💣 💥 🔥 🚒 - 9043 - Detected cloudforms
  • 💣 💥 🔥 🚒 - 9044 - Detected cfme
  • 💣 💥 🔥 🚒 - 9044 - Detected cloudforms
  • 💣 💥 🔥 🚒 - 9045 - Detected cfme
  • 💣 💥 🔥 🚒 - 9045 - Detected cloudforms
  • 💣 💥 🔥 🚒 - 9051 - Detected cfme
  • 💣 💥 🔥 🚒 - 9054 - Detected cfme
  • 💣 💥 🔥 🚒 - 9055 - Detected cloudforms
  • 💣 💥 🔥 🚒 - 9056 - Detected cloudforms
  • 💣 💥 🔥 🚒 - 9093 - Detected cfme
  • 💣 💥 🔥 🚒 - 9096 - Detected cfme
  • 💣 💥 🔥 🚒 - 9100 - Detected cfme
  • 💣 💥 🔥 🚒 - 9102 - Detected cfme
  • 💣 💥 🔥 🚒 - 9103 - Detected cloudforms
  • 💣 💥 🔥 🚒 - 9105 - Detected cloudforms
  • 💣 💥 🔥 🚒 - 9117 - Detected cfme
  • 💣 💥 🔥 🚒 - 9129 - Detected cloudforms
  • 💣 💥 🔥 🚒 - 9135 - Detected cloudforms
  • 💣 💥 🔥 🚒 - 9136 - Detected cloudforms
  • 💣 💥 🔥 🚒 - 9138 - Detected cloudforms
  • 💣 💥 🔥 🚒 - 9492 - Detected cloudforms
  • 💣 💥 🔥 🚒 - 9493 - Detected cfme
  • 💣 💥 🔥 🚒 - 9493 - Detected cloudforms
  • 💣 💥 🔥 🚒 - 9567 - Detected cloudforms
  • 💣 💥 🔥 🚒 - 9568 - Detected cfme
  • 💣 💥 🔥 🚒 - 9568 - Detected cloudforms
  • 💣 💥 🔥 🚒 - 9569 - Detected cfme
  • 💣 💥 🔥 🚒 - 9569 - Detected cloudforms
  • 💣 💥 🔥 🚒 - 9570 - Detected cloudforms
  • 💣 💥 🔥 🚒 - 9571 - Detected cfme
  • 💣 💥 🔥 🚒 - 9571 - Detected cloudforms
  • 💣 💥 🔥 🚒 - 9572 - Detected cfme
  • 💣 💥 🔥 🚒 - 9572 - Detected cloudforms
  • 💣 💥 🔥 🚒 - 9578 - Detected cfme
  • 💣 💥 🔥 🚒 - 9580 - Detected cfme
  • 💣 💥 🔥 🚒 - 9583 - Detected cfme
  • 💣 💥 🔥 🚒 - 9584 - Detected cloudforms
  • 💣 💥 🔥 🚒 - 9585 - Detected cloudforms
  • 💣 💥 🔥 🚒 - 9637 - Detected cfme
  • 💣 💥 🔥 🚒 - 9640 - Detected cfme
  • 💣 💥 🔥 🚒 - 9644 - Detected cfme
  • 💣 💥 🔥 🚒 - 9646 - Detected cfme
  • 💣 💥 🔥 🚒 - 9647 - Detected cloudforms
  • 💣 💥 🔥 🚒 - 9649 - Detected cloudforms
  • 💣 💥 🔥 🚒 - 9651 - Detected cfme
  • 💣 💥 🔥 🚒 - 9666 - Detected cfme
  • 💣 💥 🔥 🚒 - 9678 - Detected cloudforms
  • 💣 💥 🔥 🚒 - 9679 - Detected cfme
  • 💣 💥 🔥 🚒 - 9680 - Detected cfme
  • 💣 💥 🔥 🚒 - 9682 - Detected cloudforms
  • 💣 💥 🔥 🚒 - 9683 - Detected cfme
  • 💣 💥 🔥 🚒 - 9684 - Detected cfme
  • 💣 💥 🔥 🚒 - 9686 - Detected cloudforms

@miq-bot
Copy link
Member

miq-bot commented Aug 27, 2018

Checked commits Ladas/manageiq-providers-openshift@4caf5fa~...bbb855f with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 1 offense detected

spec/models/manageiq/providers/openshift/container_manager/refresher_inventory_object_spec.rb

@Ladas Ladas closed this Aug 27, 2018
@Ladas Ladas reopened this Aug 27, 2018
@Ladas Ladas closed this Aug 28, 2018
@Ladas Ladas reopened this Aug 28, 2018
Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks for the tests @Ladas !

@agrare agrare merged commit 0dd498c into ManageIQ:master Aug 28, 2018
@agrare agrare added this to the Sprint 94 Ending Sept 10, 2018 milestone Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants