-
Notifications
You must be signed in to change notification settings - Fork 51
Refresh service catalog entities specs #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh service catalog entities specs #106
Conversation
|
cc @gtanzillo |
|
Yay tests 😸
Honestly, I've lost track of what is duplicated now and what you plan to converge/drop... |
|
@cben right, it's just our shared env, so it's a random data. I'll try to setup the VCR script for it. For now we'll have at least some specs. For the new vs. old refresh. I am not sure, for now, we will focus just on entities needed by the Service Catalog and we'll expand it as needed. Right @agrare ? |
f99e266 to
bbb855f
Compare
|
Some comments on commits Ladas/manageiq-providers-openshift@4caf5fa~...bbb855f spec/vcr_cassettes/manageiq/providers/openshift/container_manager/refresher_inventory_object.yml
|
|
Checked commits Ladas/manageiq-providers-openshift@4caf5fa~...bbb855f with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 spec/models/manageiq/providers/openshift/container_manager/refresher_inventory_object_spec.rb
|
agrare
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice thanks for the tests @Ladas !
Specs for the new refresh projects, pods and the service catalog entities
Depends on: