Skip to content

[WIP] Add Windows to CI #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
agrare wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[WIP] Add Windows to CI #676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
574d3e5
Add Windows to CI
agrare Oct 16, 2025
d241b7a
Change truffleruby to go through the regular rake tests
Fryguy Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ jobs:
os:
- macos-latest
- ubuntu-latest
- windows-latest
exclude:
- os: windows-latest
ruby: truffleruby-head
runs-on: ${{ matrix.os }}
timeout-minutes: 10
env:
Expand Down
9 changes: 8 additions & 1 deletion Rakefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,19 @@ task default: %i[test rubocop]
begin
fork { nil }
rescue NotImplementedError
# jruby and windows can't fork so use vanilla rake instead
# jruby, truffleruby, and windows can't fork so use vanilla rake instead
warn 'warn: fork is not implemented on this Ruby, falling back to vanilla rake'
require 'rake/testtask'
Rake::TestTask.new do |t|
t.libs << 'test'
t.test_files = FileList['test/test_*.rb']
t.verbose = true
end
else
desc 'Run each test in isolation'
task :test do
sh 'forking-test-runner test/test_* --helper test/helper.rb --verbose'
end
end

RuboCop::RakeTask.new
3 changes: 2 additions & 1 deletion bin/ci
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@

set -e

if [[ "$OSTYPE" == "darwin"* ]]; then
echo $OSTYPE
if [[ "$OSTYPE" != "linux-gnu" ]]; then
Copy link
Member Author

@agrare agrare Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE I saw something said bash on windows was reported as linux-gnu to I added an echo to see what we get on the windows-latest runners

bundle exec rake test
else
# Sometimes minitest starts and then just hangs printing nothing.
Expand Down
Loading