bearer_token_file: load inline #537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cben
reviewed
Feb 21, 2022
cben
reviewed
Feb 21, 2022
cben
reviewed
Feb 21, 2022
grosser
approved these changes
Feb 21, 2022
Contributor
grosser
left a comment
grosser
left a comment
There was a problem hiding this comment.
nice approach!
... yeah careful with watch
the audit log should show which request was stale too so you can see if the problem was watch or regular calls
Contributor
|
FYI this fixes #525 too :D |
Collaborator
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simplify loading the bearer token from file, to just reading it inline. The previous approach with refreshing the token from file from various points, seems to have missed something - we were still flagged by the audit logging on our k8s clusters.