Skip to content

Conversation

@grosser
Copy link
Contributor

@grosser grosser commented Dec 12, 2021

fixes #521

TODO: confirm it actually works (can check Monday)

@cben
Copy link
Collaborator

cben commented Dec 15, 2021

Code looks good, though I don't know much about the feature.
Have you confirmed it actually works?

@grosser
Copy link
Contributor Author

grosser commented Dec 15, 2021

I'm blocked by the ssl being broken in master :(
#525
in theory it should work since that's what I've been doing manually before (setting the headers)
if the ssl issue is hard to fix I can try rebasing this on 4.9 to do an end-to-end test ...

@cben
Copy link
Collaborator

cben commented Jul 24, 2022

Just a reminder SSL issues (that I'm aware of) have been fixed.

@DocX
Copy link
Contributor

DocX commented Jan 20, 2023

Hi @grosser I've updated your work to latest master and tested it works. I've run into the missing impersonation when working on our internal project. Getting the update makes it work.

I've made new PR here: #600 but feel free to update this PR if you think you would loose the credit :)

@grosser
Copy link
Contributor Author

grosser commented Jan 20, 2023

the less my name is in git blame the better :D

@grosser grosser closed this Jan 20, 2023
@grosser grosser deleted the grosser/impersonate branch January 20, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

support impersonation

3 participants