Skip to content

Conversation

@grosser
Copy link
Contributor

@grosser grosser commented Mar 6, 2021

#494 breaks when VCR is enabled .. somehow it ends up executing the stubs on all threads

can reproduce by adding to test/test_helper.rb

require 'vcr'
VCR.configure do |c|
  c.cassette_library_dir = 'test/cassettes'
  c.hook_into(:webmock)
end

and running ruby test/test_informer.rb

the guestbook test itself seems rather brittle / not reproducible, so I'm thinking best get rid of it instead of pouring more work into it

@cben
Copy link
Collaborator

cben commented Mar 6, 2021

I guess you're right.

I was recently thinking to automate some version of k8s that's easy to start, e.g. k3s, to be able to reproducibly re-record it the VCR. But if we make something like that, we don't need VCR, we could get real end-to-end testing. As it is, the VCR test is not worth much.

@cben
Copy link
Collaborator

cben commented Mar 6, 2021

Don't know yet what's going on with truffleruby. Added it to #435 checklist so we don't forget. This PR is obviously safe, merging.

@cben cben merged commit 6dd1a62 into ManageIQ:master Mar 6, 2021
@grosser grosser deleted the grosser/webmock branch March 6, 2021 22:11
cben added a commit to cben/kubeclient that referenced this pull request Feb 27, 2022
VCR was interfering with my attempts to connect to a real cluster,
despite `WebMock.enable_net_connect!`.
What's worse, it depended on order that tests executed.

[This won't be needed on master, we dropped the VCR test in ManageIQ#495.]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants