Conversation
bmh7190
commented
Feb 15, 2025
| raise serializers.ValidationError("유효한 사용자 정보를 찾을 수 없습니다.") | ||
|
|
||
| user = request.user # request.user 사용 | ||
|
|
Contributor
Author
There was a problem hiding this comment.
여기서 http body로 user_id로 받던거 수정했습니다!
|
|
||
| serializer = CreateCourseSerializser(data=request.data, context={'request': request}) | ||
| serializer = CreateCourseSerializer(data=request.data, context={'request': request}) | ||
|
|
Contributor
Author
There was a problem hiding this comment.
시리얼라이저 오타가 있길래 그것도 수정해줬어요!
| 'SIGNING_KEY': 'hellomakourse', | ||
| 'ACCESS_TOKEN_LIFETIME': timedelta(hours=1), | ||
| 'ACCESS_TOKEN_LIFETIME': timedelta(days=30), | ||
| 'REFRESH_TOKEN_LIFETIME': timedelta(days=7), |
Contributor
Author
There was a problem hiding this comment.
Accesstoken 기한 30일로 변경해서 개발하는데 편리하게 해줬습니다!
Contributor
|
수정한 코드들은 모두 괜찮은거 같습니다! 그리고 일정 이름은 null로 뜨지 않게 처음 사용자가 이름을 정하기 않았더라면 defalut로 생성일자를 이름으로 설정하든지 아니면 "이름을 정해주세요"라는걸로 해넣든지 하는건 어떻게 생각하시나요?? |
Contributor
Author
|
아하 default 값 정해주는거 좋은거 같습니다! "이름을 정해주세요"로 하겠습니다! 그리고 1번부터 시작하도록 지정해불게요! |
bmh7190
commented
Feb 15, 2025
| meet_date_third = models.DateTimeField(null=True , blank= True) | ||
| course_name = models.CharField(max_length=20, null=True, blank= True) | ||
| course_name = models.CharField(max_length=20, blank=True, default="일정 이름을 정해주세요") | ||
| meet_place = models.CharField(max_length=50, null=True, blank= True) |
Contributor
Author
There was a problem hiding this comment.
여기 "일정 이름을 정해주세요" 로 default값을 수정했슴다!
bmh7190
commented
Feb 15, 2025
| if not self.entry_name: | ||
| self.entry_name = f"{self.num}번째 일정" | ||
|
|
||
| super().save(*args, **kwargs) # 부모 클래스의 save 호출 |
Contributor
Author
There was a problem hiding this comment.
여기서 1번 부터 시작하도록 바꿔줬고, 위와 같은 이유로 default 값을 지정해줬습니다!
Contributor
|
확인했습니다! 머지해도 될거같아요 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue 🚀
Work Description 💚
PR 참고 사항