Skip to content

Enforce that all axis types are <: AbstractAxis #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asinghvi17 wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Enforce that all axis types are <: AbstractAxis #564

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
81c3f7f
Enforce that all axis types are <: AbstractAxis
asinghvi17 Sep 19, 2024
4bfb769
Merge remote-tracking branch 'origin/master' into as/no_hardcoded_axi…
asinghvi17 Dec 14, 2024
d7c833d
Merge branch 'master' into as/no_hardcoded_axis_types
asinghvi17 Jan 27, 2025
5a8da99
Merge branch 'master' into as/no_hardcoded_axis_types
asinghvi17 Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/entries.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ end
# Use technique from https://github.com/MakieOrg/AlgebraOfGraphics.jl/pull/289
# to encode all axis information without creating the axis.
struct AxisSpec
type::Union{Type{Axis}, Type{Axis3}}
type::Type{<: Makie.AbstractAxis}
position::Tuple{Int,Int}
attributes::NamedArguments
end
Expand Down Expand Up @@ -59,7 +59,7 @@ Each categorical scale should be a `CategoricalScale`, and each continuous
scale should be a `ContinuousScale`.
"""
struct AxisEntries
axis::Union{Axis, Axis3}
axis::Makie.AbstractAxis
entries::Vector{Entry}
categoricalscales::MultiAesScaleDict{CategoricalScale}
continuousscales::MultiAesScaleDict{ContinuousScale}
Expand Down
Loading