fix: resolve issues #1082, #1083, #1084, #1085

[Mystery-CLI]

Summary

This PR addresses four issues across router-timelock, router-access, and router-quote contracts:

1. test(router-timelock): get_operations_by_status has no test coverage #1085: Add test coverage for get_operations_by_status.
2. bug(router-access): MaxGrantsPerRoleExceeded check reads RoleMemberCount after it was already incremented, off-by-one #1084: Fix off-by-one check in MaxGrantsPerRoleExceeded.
3. bug(router-quote): get_all_configured_routes reports the flat/default fee for routes configured only via fee tiers #1083: Report tier fee in get_all_configured_routes.
4. feat(router-timelock): queue() does not validate that dependency op_ids reference existing operations #1082: Validate that dependency op_ids reference existing operations in queue().

Changes

router-timelock

• test(router-timelock): get_operations_by_status has no test coverage #1085: Added dedicated unit tests for get_operations_by_status covering Queued, Ready, and Expired status filtering and payload correctness.
• feat(router-timelock): queue() does not validate that dependency op_ids reference existing operations #1082: Added check in queue() ensuring each dependency dep_id in deps exists in storage (DataKey::Op(dep_id)), returning TimelockError::NotFound when referencing non-existent operations.

router-access

• bug(router-access): MaxGrantsPerRoleExceeded check reads RoleMemberCount after it was already incremented, off-by-one #1084: Fixed off-by-one check where RoleMemberCount was incremented prior to checking MaxGrantsPerRoleExceeded, ensuring roles can reach their full configured capacity of active members.

router-quote

• bug(router-quote): get_all_configured_routes reports the flat/default fee for routes configured only via fee tiers #1083: Updated get_all_configured_routes() to inspect configured fee tiers first (reporting the lowest tier's fee_bps) before falling back to the flat route fee / default fee.

Closes #1082
Closes #1083
Closes #1084
Closes #1085

[drips-wave]

@Mystery-CLI Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits