Fix Player.cpp to use metric, then switch back to previously set unit#20
Open
Ajeff22209 wants to merge 1 commit intoMakeraInc:masterfrom
Open
Fix Player.cpp to use metric, then switch back to previously set unit#20Ajeff22209 wants to merge 1 commit intoMakeraInc:masterfrom
Ajeff22209 wants to merge 1 commit intoMakeraInc:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was an issue where M600 would cause a soft limit error when run in G20. The machine would save the position of the spindle in millimeters regardless of G20 or G21. Then, when the user resumes the program, it would attempt to return to the saved position but would execute the Gcode command in whatever state the machine was in when it paused. This would cause a soft limit error in almost all cases. If the spindle was close enough to the WCS zero it would work but it would move to those coordinates in inches, which could cause a crash as Z could move down. We added a G21 to the line that executes the return to save position and had the machine return to the original unit system afterwards via another snprintf line. We have tested this in both G20 and G21 and it functions as normal, just minus the soft limit error.