This repository was archived by the owner on May 29, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 151
spell-check and re-word beginning of covid-19 dungeon for readability #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
suggested changes
Dec 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good. But, as you have changed the go into dungeon text, you may need to link it to another document (3
maybe?).
Please fix the linking & the content of the story.
Fixed linking issue that @paulsonjpaul spotted, then resolved merge conflict with #123 that fixed WIP link |
Good. Now it makes sense. Add some emojis 😉 |
Hi @Gborgman05 and @paulsonjpaul, |
Kudos, SonarCloud Quality Gate passed! |
@ming-tsai , @paulsonjpaul , just added some emojis to spice up the route. I'd love any feedback! |
ming-tsai
approved these changes
Dec 28, 2020
Nice work @Gborgman05 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
beginner
Need more contributors
documentation
Improvements or additions to documentation
enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#112 fixed spelling. The route had an option to just "go into the dungeon" which didn't make sense if you were chained to a post, but another route has you break the chain after getting strong, so I don't know what we should do.