Skip to content
This repository has been archived by the owner on May 29, 2024. It is now read-only.

docs: add movie quote generator #123

Merged
merged 4 commits into from
Oct 25, 2022
Merged

docs: add movie quote generator #123

merged 4 commits into from
Oct 25, 2022

Conversation

kamiri-charles
Copy link
Contributor

No description provided.

@welcome
Copy link

welcome bot commented Oct 12, 2022

Thanks for opening this pull request! Please check out our contributing guidelines.

@ming-tsai ming-tsai changed the title Added my project for as a recomendation. docs: add movie quote generator Oct 16, 2022
Copy link
Member

@ming-tsai ming-tsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kamiri-charles,
Great work!!!, but could you add the idea to ideas.json? make sure the first tag of the idea should with quote-generator

@ming-tsai ming-tsai added the documentation Improvements or additions to documentation label Oct 16, 2022
Copy link
Contributor Author

@kamiri-charles kamiri-charles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ming-tsai, edited ideas.json as requested.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ming-tsai ming-tsai merged commit 5a92d71 into MakeContributions:main Oct 25, 2022
@welcome
Copy link

welcome bot commented Oct 25, 2022

Congrats on merging your first pull request! We here at MakeContributions are proud of you! 🎉🎉🎉🎉.
You are invited to join the team on Github and Discord.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants