Skip to content
This repository has been archived by the owner on May 29, 2024. It is now read-only.

fix: project URL accessibility #120

Merged
merged 1 commit into from Oct 12, 2022
Merged

fix: project URL accessibility #120

merged 1 commit into from Oct 12, 2022

Conversation

ghost
Copy link

@ghost ghost commented Oct 8, 2022

Resolves #119 by fixing case-sensitive URL for projects page.

Implements the following small accessibility fixes:

  • Missing label on search input
  • Hides disabled idea button / icon from accessibility API
  • Add screen reader only (via Vuetify utility class) text to Projects search button and GitHub repo links

@welcome
Copy link

welcome bot commented Oct 8, 2022

Thanks for opening this pull request! Please check out our contributing guidelines.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ming-tsai ming-tsai assigned ghost Oct 9, 2022
@ming-tsai ming-tsai added the bug Something isn't working label Oct 9, 2022
@ming-tsai ming-tsai changed the title Project URL + Accessibility Fixes fix: project URL accessibility Oct 9, 2022
@ming-tsai ming-tsai self-requested a review October 9, 2022 04:18
@ming-tsai ming-tsai merged commit 504056f into MakeContributions:main Oct 12, 2022
@welcome
Copy link

welcome bot commented Oct 12, 2022

Congrats on merging your first pull request! We here at MakeContributions are proud of you! 🎉🎉🎉🎉.
You are invited to join the team on Github and Discord.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential changes need to project links
2 participants