Skip to content
This repository has been archived by the owner on May 29, 2024. It is now read-only.

docs(projects): add pokemon awesome #116

Merged

Conversation

shonenxnaifu
Copy link
Member

No description provided.

@shonenxnaifu shonenxnaifu changed the title add project Pokemon Awesome add Pokemon Awesome project Oct 6, 2022
Copy link
Contributor

@ahmedsilat44 ahmedsilat44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ahmedsilat44
Copy link
Contributor

I think you should also update docs accordingly. Like if your project is website intermediate add your project to docs/WEBSITE_INTERMEDIATE.md

@shonenxnaifu
Copy link
Member Author

shonenxnaifu commented Oct 6, 2022

I think you should also update docs accordingly. Like if your project is website intermediate add your project to docs/WEBSITE_INTERMEDIATE.md

thanks for your suggestion, i will update the docs soon. Because this web is on advanced level, can i add new file WEB_ADVANCED on folder docs? @ahmedsilat44

- add category new category website on file readme.md
- add new file WEBSITE_ADVANCED.md in docs folder
@ahmedsilat44
Copy link
Contributor

I think you should also update docs accordingly. Like if your project is website intermediate add your project to docs/WEBSITE_INTERMEDIATE.md

thanks for your suggestion, i will update the docs soon. Because this web is on advanced level, can i add new file WEB_ADVANCED on folder docs? @ahmedsilat44

Yea I guess you should do that

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@shonenxnaifu
Copy link
Member Author

i'm already added new website category and fixed merge confilct kindly check my pr @ahmedsilat44

@ming-tsai ming-tsai changed the title add Pokemon Awesome project docs(projects): add pokemon awesome Oct 6, 2022
@ming-tsai ming-tsai merged commit 70c3064 into MakeContributions:main Oct 6, 2022
@ahmedsilat44
Copy link
Contributor

i'm already added new website category and fixed merge confilct kindly check my pr @ahmedsilat44

I can't do that I am just a random contributor 😂

@shonenxnaifu
Copy link
Member Author

i'm already added new website category and fixed merge confilct kindly check my pr @ahmedsilat44

I can't do that I am just a random contributor 😂

sorry 😂 i thought you were a maintainer @ahmedsilat44

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants