-
-
Notifications
You must be signed in to change notification settings - Fork 668
Feat/shadcn themes #912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: staging
Are you sure you want to change the base?
Feat/shadcn themes #912
Conversation
…th connection support
…ing and font integration
…provider for font, spacing, and shadow management
…opover, and various states; enhance theme editor for better color handling
…main navigation; enhance theme preview with interactive elements and improved styling
…tor; enhance theme actions with update method for better theme management
… management with new preset options; update theme actions for better integration
…s for backgrounds and borders; improve consistency across UI elements
…old Tech, Bubblegum, and Caffeine; enhance theme management with additional preset creation functionality
@umarhadi is attempting to deploy a commit to the Zero Team on Vercel. A member of the Team first needs to authorize it. |
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
done |
…ve legacy theme actions and enhance theme creation and management functionality
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haven't tested but looks good, please sync with react query code
any update of this? @ahmetskilinc @MrgSub |
@BlankParticle please review trpc usage |
still making up own hooks using the base trpc client instead of just using the integrated |
e47318e
to
a6ec63a
Compare
Description
This pull request introduces a custom theming system, fulfilling the requirements outlined in /claim #883.
Users can now create, customize, manage, and apply detailed themes to personalize their mail client experience via the
/settings/themes
page. Themes are persisted to the database and can be applied to the active connection. When a connection is active, its associated theme (if any) is loaded automatically.Key features include:
CustomThemeProvider
to dynamically load themes and inject CSS variables.Type of Change
Please delete options that are not relevant.
Areas Affected
Please check all that apply:
theme
table,ThemeSettings
type)Testing Done
Describe the tests you've done:
/settings/themes
.tls
are resolved.Security Considerations
For changes involving data or authentication:
Checklist
Additional Notes
/settings/themes
page for the active connection. The original requirement to add theme selection directly to the connection setup screen is not included here and could be a separate enhancement.muted
,accent
, etc.) for the sidebar. If independent sidebar theming is desired in the future, theThemeSettings
schema andCustomThemeProvider
will need updates to handle specific--sidebar-*
variables.Screenshots/Recordings
1746735651962054.mp4
By submitting this pull request, I confirm that my contribution is made under the terms of the project's license.