Skip to content

Feat/shadcn themes #912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 19 commits into
base: staging
Choose a base branch
from
Open

Conversation

umarhadi
Copy link

@umarhadi umarhadi commented May 8, 2025

Description

This pull request introduces a custom theming system, fulfilling the requirements outlined in /claim #883.

Users can now create, customize, manage, and apply detailed themes to personalize their mail client experience via the /settings/themes page. Themes are persisted to the database and can be applied to the active connection. When a connection is active, its associated theme (if any) is loaded automatically.

Key features include:

  • Database schema and server actions for theme CRUD operations, user/connection association, and public sharing status.
  • A theme editor with live preview for customizing colors, fonts, spacing, shadows, corner radius, and backgrounds (color, gradient, image).
  • A management UI to view, create, edit, delete, and apply themes.
  • A CustomThemeProvider to dynamically load themes and inject CSS variables.
  • Several preset themes (Light, Dark, Sunset Horizon, Cyberpunk, Amber Minimal, Amethyst Haze, Bold Tech, Bubblegum, Caffeine) with light/dark variants, addable via a button in settings.
  • Fixes for previous issues where UI elements (main layout, sidebar, compose button/dialog, mail panels) did not respect theme changes.
  • Resolution of client-side build errors related to server-only code imports.

Type of Change

Please delete options that are not relevant.

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature with breaking changes)
  • 📝 Documentation update
  • 🎨 UI/UX improvement
  • 🔒 Security enhancement
  • ⚡ Performance improvement

Areas Affected

Please check all that apply:

  • Email Integration (Gmail, IMAP, etc.)
  • User Interface/Experience
  • Authentication/Authorization (Server actions check session)
  • Data Storage/Management (New theme table, ThemeSettings type)
  • API Endpoints (Via Next.js Server Actions)
  • Documentation
  • Testing Infrastructure
  • Development Workflow
  • Deployment/Infrastructure

Testing Done

Describe the tests you've done:

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed:
    • Verified theme creation, editing (with live preview), and deletion in /settings/themes.
    • Tested applying various themes (presets, custom, light/dark) and confirmed immediate UI updates for sidebar, main mail layout, mail list/view panels, compose button/dialog.
    • Confirmed "Add Preset Themes" button adds missing themes correctly.
    • Tested theme persistence across page reloads/sessions.
    • Verified "Reset to Default" functionality.
    • Confirmed build errors related to tls are resolved.
  • Cross-browser testing (if UI changes) - (Please specify browsers tested if applicable)
  • Mobile responsiveness verified (if UI changes) - (Theme settings page/editor might need specific mobile testing)

Security Considerations

For changes involving data or authentication:

  • No sensitive data is exposed (Theme settings are generally cosmetic)
  • Authentication checks are in place (Server actions verify user session before performing theme operations)
  • Input validation is implemented (Basic validation via types, further sanitization might be needed for image URLs/gradients)
  • Rate limiting is considered (if applicable) - (Not implemented, potentially needed for public theme creation/sharing)

Checklist

  • I have read the CONTRIBUTING document
  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in complex areas
  • I have updated the documentation - (Documentation needs update for the new theme system)
  • My changes generate no new warnings
  • I have added tests that prove my fix/feature works - (No automated tests added)
  • All tests pass locally - (Assuming manual tests pass)
  • Any dependent changes are merged and published

Additional Notes

  • This implementation adds theme selection/application primarily through the /settings/themes page for the active connection. The original requirement to add theme selection directly to the connection setup screen is not included here and could be a separate enhancement.
  • The system currently uses general theme colors (muted, accent, etc.) for the sidebar. If independent sidebar theming is desired in the future, the ThemeSettings schema and CustomThemeProvider will need updates to handle specific --sidebar-* variables.

Screenshots/Recordings

1746735651962054.mp4

By submitting this pull request, I confirm that my contribution is made under the terms of the project's license.

umarhadi added 12 commits May 8, 2025 19:51
…provider for font, spacing, and shadow management
…opover, and various states; enhance theme editor for better color handling
…main navigation; enhance theme preview with interactive elements and improved styling
…tor; enhance theme actions with update method for better theme management
… management with new preset options; update theme actions for better integration
…s for backgrounds and borders; improve consistency across UI elements
…old Tech, Bubblegum, and Caffeine; enhance theme management with additional preset creation functionality
Copy link

vercel bot commented May 8, 2025

@umarhadi is attempting to deploy a commit to the Zero Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented May 8, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@umarhadi
Copy link
Author

umarhadi commented May 8, 2025

wrong base branch, sorry, ill do it again

done

@umarhadi umarhadi changed the title Feat/shadcn themes [WIP]Feat/shadcn themes May 8, 2025
@umarhadi umarhadi changed the title [WIP]Feat/shadcn themes Feat/shadcn themes May 8, 2025
Copy link
Collaborator

@MrgSub MrgSub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haven't tested but looks good, please sync with react query code

@umarhadi umarhadi requested a review from MrgSub May 9, 2025 07:41
@umarhadi
Copy link
Author

any update of this? @ahmetskilinc @MrgSub

@MrgSub
Copy link
Collaborator

MrgSub commented May 16, 2025

@BlankParticle please review trpc usage

@BlankParticle
Copy link
Collaborator

@BlankParticle please review trpc usage

still making up own hooks using the base trpc client instead of just using the integrated useTrpc hook and using the auto generated queryQptions from that

@BlankParticle BlankParticle force-pushed the staging branch 6 times, most recently from e47318e to a6ec63a Compare May 30, 2025 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants