new-changes in the main - #35
Conversation
Merged via #27. Thanks for the contribution, @Ujawala10! All four badges are now live on the README — Maven Central, CI status, Java 17+, and MIT License. This closes #24.
Add TROUBLESHOOTING.md with 6 FAQ entries covering common issues: - Errors not appearing on APM dashboard - Health endpoint 429 rate limiting - Sensitive headers in payloads - Excluded paths still being dispatched - SDK active in local/test environments - Duplicate log entries on APM dashboard Add Troubleshooting section to README.md linking to the new file. Co-Authored-By: Paperclip <noreply@paperclip.ing>
Remove references to logdispatch.enabled property which is not yet available (tracked in issue #21). Changes: - Q&A 1: remove 'SDK disabled' bullet and enabled in config snippet - Health 429 Q&A: replace enabled reference with link to issue #14 - Remove local/test environment Q&A entirely Co-Authored-By: Paperclip <noreply@paperclip.ing>
docs: add troubleshooting guide with FAQ
Expand LogDispatchFilter test coverage
Refactor README for improved clarity and structure.
docs: add application.properties configuration example
…payload structure
…and create TESTING.md
…er-category Feat/add new security filter category
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 59be9a4784
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <groupId>in.maheshlangote</groupId> | ||
| <artifactId>logdispatch-spring-boot-starter</artifactId> | ||
| <version>1.0.6</version> | ||
| <version>1.0.7</version> |
There was a problem hiding this comment.
This bump moves the artifact to 1.0.7, but the README installation snippet still tells users to depend on 1.0.6. In a release where users copy that snippet, they will install the previous artifact and miss the new SECURITY severity/payload changes advertised by the changelog, so please update the snippet or replace it with a version placeholder.
Useful? React with 👍 / 👎.
| exclude-paths: "/health,/actuator/**,/metrics/**,/swagger-ui/**" | ||
| ``` | ||
|
|
||
| > **Note:** The `/logdispatch/health` endpoint is automatically excluded and does not need to be added to `exclude-paths`. |
There was a problem hiding this comment.
This note is false for the code in this commit: the auto-configuration passes only the configured excludePaths into LogDispatchFilter, and the filter only matches that list, so /logdispatch/health is not excluded unless users add it themselves. In applications relying on this note, rate-limited health checks that return 429 will still be dispatched as SECURITY events to the APM server, creating noisy self-monitoring logs.
Useful? React with 👍 / 👎.
Signed-off-by: 박상원 <63744049+wipheg@users.noreply.github.com>
feat: add configurable connection and read timeouts
docs: add LogDispatch example Spring Boot app
feat: add logdispatch enabled toggle
7 participants
No description provided.