Skip to content

add error handling to weather fetch functions, including cors #3791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

add error handling to weather fetch functions, including cors #3791

wants to merge 2 commits into from

Conversation

sdetweil
Copy link
Collaborator

add error detection and handling for weather and cors fetch

fixes #3687

rejas
rejas reviewed May 26, 2025
View reviewed changes
@sdetweil sdetweil added the draft label May 26, 2025
@sdetweil
Copy link
Collaborator Author

all tests run locally, electron and e2e

@khassel
Copy link
Collaborator

khassel commented May 26, 2025

all tests run locally, electron and e2e

the 2 failed tests are unit tests - and they fail if I run them locally ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rejas rejas rejas left review comments

Assignees
No one assigned
Labels
draft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sdetweil @khassel @rejas