Skip to content

fix: allow taskless hotfix closure #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MageByte-Zero merged 1 commit into from
Jul 21, 2026
Merged

fix: allow taskless hotfix closure #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions scripts/guard/guard.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ const WORKFLOW_TRANSITION_CHECKS = {
'exploring:bridging': [],
'bridging:approved-for-build': ['contract-current', 'dp3-approved'],
'approved-for-build:executing': ['contract-current', 'dp3-approved', 'execution-plan-ready'],
'executing:closing': ['tests-passing', 'specs-merged', 'execution-plan-ready', 'execution-reviews-passed'],
},
tweak: {
'exploring:approved-for-build': [],
Expand Down
31 changes: 31 additions & 0 deletions tests/lib/guard.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,37 @@ describe('guard: hotfix minimal contract', () => {
const dims = result.output.checks.map(c => c.dimension);
assert.deepEqual(dims, ['contract-current', 'dp3-approved', 'execution-plan-ready']);
});

it('allows a reviewed hotfix without tasks.md to enter closing', () => {
rmSync(dir, { recursive: true, force: true });
mkdirSync(dir, { recursive: true });
writeFileSync(join(dir, 'execution-contract.md'), '# Execution Contract\n\n## Intent Lock\n\nHotfix closing contract.\n');
runNodeScript(CLI_PATH, ['state', 'init', dir]);
runNodeScript(CLI_PATH, ['state', 'set', dir, 'workflow', 'hotfix']);
const refs = initializeGitRepository(dir);

runNodeScript(CLI_PATH, ['execution', 'recommend', dir, '--wave', 'wave-1:serial:1.1']);
runNodeScript(CLI_PATH, ['execution', 'plan', dir, '--mode', 'inline', '--confirm',
'--reason', 'user-selected hotfix closing plan', '--wave', 'wave-1:serial:1.1']);

const reportsDir = join(dir, '.superpowers', 'sdd', 'reviews');
mkdirSync(reportsDir, { recursive: true });
writeFileSync(join(reportsDir, 'wave-1.md'), 'Hotfix review passed.\n');
runNodeScript(CLI_PATH, ['execution', 'review', dir, '--wave', 'wave-1',
'--base', refs.base, '--head', refs.head, '--report', '.superpowers/sdd/reviews/wave-1.md', '--verdict', 'pass']);
runNodeScript(CLI_PATH, ['state', 'set', dir, 'test_result', 'pass']);
runNodeScript(CLI_PATH, ['state', 'set', dir, 'spec_merged', 'true']);

const result = run('executing', 'closing');

assert.equal(result.exitCode, 0, JSON.stringify(result.output));
assert.deepEqual(result.output.checks.map(check => check.dimension), [
'tests-passing',
'specs-merged',
'execution-plan-ready',
'execution-reviews-passed',
]);
});
});

describe('guard: execution control records', () => {
Expand Down
Loading