fix: make closing a true terminal state#66
Merged
Conversation
MageByte-Zero
marked this pull request as ready for review
July 19, 2026 08:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
变更说明
修复 #64,使
closing在所有工作流表面和权威运行时中都成为真正的成功终态。workflow-start在 update、handoff/checkpoint overlay 与 execution-control 扫描前短路closing,返回CLOSED/next skill: nonerelease-archivist与spec-merger仅允许在executing中运行,并在任何 audit、DP 写入或 spec sync 副作用前校验持久化状态closing → specifyingguard 出边,七个 closing 出边现在都返回结构化非法转换结果workflow-routing规格根因
ssf list已将closing映射为CLOSED,但 canonical skills、phase guard 和状态机文档仍把 closing 当成活跃收口阶段;同时运行时矩阵保留了closing:specifying,导致“终态”只存在于部分表面。验证
npm run build:通过node --test tests/lib/guard-transitions.test.mjs tests/lib/closing-terminal-semantics.test.mjs:60/60 通过node --test tests/lib/cmd-inject.test.mjs:21/21 通过npm run validate -- changes/fix-closing-terminal-routing:0 errors / warningsnode scripts/lint/lint-skills.mjs:0 errorsgit diff --check:通过本机 Node 24 完整测试为 435 项、429 通过、6 失败;失败仅来自两个既有测试 helper 的固定
timeout: 5000(guard-specs-merged、guard-tests-passing),未修改相关文件,且同路径后续用例通过。仓库 CI 将继续在 Node 20/22 验证。Closes #64