Add catch error to method getResponseBody()

MacPaw · Dec 16, 2020 · 17c9132 · 17c9132
1 parent 54d871a
commit 17c9132
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/lib/request-helper.js b/lib/request-helper.js
@@ -21,22 +21,21 @@ module.exports = {
     const response = await request(method, url, options);
     log(`Server responded with status code: '${response.statusCode}' and body: ${response.body.toString()}'`);
 
-    this.catchError(response);
-
     return response;
   },
 
   getResponseBody(response) {
+    this.catchError(response);
     const body = response.body.toString();
 
     return body ? JSON.parse(body) : {};
   },
 
   catchError(response) {
     const {statusCode} = response;
-    const body = response.body.toString();
 
     if (!this.isSuccess(statusCode)) {
+      const body = response.body.toString();
       throw new Error(`Oops, the server responded with status code: '${statusCode}' and body: ${body}`);
     }
   },

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@macpaw/qa-api-services",
-  "version": "2.0.0",
+  "version": "2.1.0",
   "description": "QA API libraries for MacPaw projects",
   "main": "index.js",
   "author": "Volodymyr Dobrygin",