Fix: Rename redundant type names #209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nezhyborets
approved these changes
Jan 17, 2025
Collaborator
nezhyborets
left a comment
nezhyborets
left a comment
There was a problem hiding this comment.
Great! More laconic and Swifty. We may also remove all the Self. as it seems redundant. But we can do it in another PR
wangqi
pushed a commit
to wangqi/OpenAI
that referenced
this pull request
Feb 18, 2025
Fix: Rename redundant type names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Renamed some redundant type names such as
ChatCompletionMessageParam.ChatCompletionSystemMessageParam->ChatCompletionMessageParam.SystemMessageParam.Why
In Swift, the names of types within the nested structure usually omit the namespace prefix.
This fix improves the readability:
[Before]
ChatCompletionMessageParam.ChatCompletionSystemMessageParamChatCompletionMessageParam.ChatCompletionUserMessageParamChatCompletionMessageParam.ChatCompletionAssistantMessageParamChatCompletionMessageParam.ChatCompletionToolMessageParam[After]
ChatCompletionMessageParam.SystemMessageParamChatCompletionMessageParam.UserMessageParamChatCompletionMessageParam.AssistantMessageParamChatCompletionMessageParam.ToolMessageParam