FIX for #841: NPTR causing crash to desktop due to etching acid missing icon#898
Open
LachimHeigrim wants to merge 1 commit intoMaartenKok8:masterfrom
Open
FIX for #841: NPTR causing crash to desktop due to etching acid missing icon#898LachimHeigrim wants to merge 1 commit intoMaartenKok8:masterfrom
LachimHeigrim wants to merge 1 commit intoMaartenKok8:masterfrom
Conversation
…ons, causing crash to desktop when acid was placed. Additionally the world would not load and repeat crashing. Resolution: Added both still and flow icons based on recolored kerosene icon and registered them properly in BlockFluidEtchingAcid.
Contributor
|
The last activity in the mod was roughly one year ago, this will likely not be merged in the official branch. |
Author
|
Has @MineMaarten gave up maintenance of completely? I believe I read on his twitter he does not plan to update to 1.8 and further, but since there are still packs and servers on 1.7.10 in common use, fixing CTDs like this is just common courtesy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Etching acid fluid returned NULL for still and flow icons, causing crash to desktop when acid was placed into Mariculture vat. Additionally the world would not load and repeat crashing as vat was being rendered.
Resolution: Added both still and flow icons based on recolored kerosene icon and registered them properly in BlockFluidEtchingAcid.