Repository navigation
Enable ruff rule RUF - #2457
Merged
Merged
Enable ruff rule RUF#2457
RUF#2457Conversation
afuetterer
marked this pull request as draft
November 12, 2025 08:07
afuetterer
marked this pull request as ready for review
November 12, 2025 08:14
Owner
|
Looks great to me! Thanks again for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Discussion at #2450
-->
If you add the type hint
Union[int, str]you should not use a default value of None.It also sorts entries in
__all__alphabetically.This
RUF015 unnecessary-iterable-allocation-for-first-elementmight actually be a little faster. You don't need to convert result of zip to list to access first entry.Summary:
Before submitting