Repository navigation
Address logical gaps in electronics and simulation logic - #215
Conversation
This commit addresses several missing pieces of functionality:
1. Added `Switch` class and battery options ('6V-Battery', '12V-Battery') to `shared/cots/parts/electronics.py`.
2. Updated `calculate_assembly_totals` in `worker_heavy/utils/validation.py` to handle all `ElectronicComponentType` values (RELAY, SWITCH, CONNECTOR).
3. Improved out-of-bounds detection in `SimulationLoop.step` to check all active bodies, not just the target object.
4. Refined `SuccessEvaluator.check_failure` with better defaults for out-of-bounds detection.
5. Integrated `Switch` class into the `Indexer` in `shared/cots/indexer.py`.
Co-authored-by: MRiabov <108194191+MRiabov@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Identified and implemented several logical gaps in the codebase:
Switchclass and battery variants (6V, 12V) which were defined in the system but missing implementation.PR created automatically by Jules for task 6714645028108848135 started by @MRiabov