-
Notifications
You must be signed in to change notification settings - Fork 0
#6 - listing image uploads backend #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request implements backend functionality for auction listing image uploads with a reporting system. The main changes include replacing the photo URL field with actual file uploads, implementing a report system for auctions, and adding identicon generation as a fallback for auction images.
Key Changes:
- Replaced photo URL string field with file upload functionality for auctions
- Added a complete reporting system for auctions (create, view, list reports)
- Implemented image storage using Laravel's filesystem with a dedicated "auctionImage" disk
- Added identicon generation as fallback for auction images
- Created Report model with relationships to User and Auction
Reviewed changes
Copilot reviewed 28 out of 31 changed files in this pull request and generated 15 comments.
Show a summary per file
| File | Description |
|---|---|
| database/migrations/0001_01_01_000004_create_auctions_table.php | Removed photo_url column from auctions table |
| database/migrations/0001_01_01_000005_create_reports_table.php | Created reports table with foreign keys to users and auctions |
| app/Models/Auction.php | Added photo attribute accessor using IdenticonHelper |
| app/Models/Report.php | New Report model with reporter and auction relationships |
| app/Http/Controllers/Auction/AuctionController.php | Added image upload and retrieval endpoints |
| app/Http/Controllers/Auction/ReportController.php | New controller for report CRUD operations |
| app/Helpers/IdenticonHelper.php | Helper class for generating identicon URLs |
| config/filesystems.php | Added auctionImage disk configuration |
| routes/web.php | Added report routes and auction image endpoint |
| resources/js/Pages/Auction/CreateAuction.tsx | Updated form to support file upload |
| resources/js/Pages/Auction/ReportAuction.tsx | New report creation form |
| resources/js/Pages/Auction/ShowReport.tsx | New report detail view |
| composer.json | Added yzalis/identicon dependency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AmonDeShir
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wygląda wszystko dobrze, ale czekamy na #44
…ads-Backend # Conflicts: # app/Actions/Auction/CreateReportAction.php # app/Http/Controllers/Auction/ReportController.php # app/Http/Requests/Auction/CreateReportRequest.php # app/Http/Resources/ReportResource.php # app/Models/Auction.php # app/Models/Report.php # database/factories/ReportFactory.php # resources/js/Pages/Auction/ReportAuction.tsx # resources/js/Pages/Auction/ShowReport.tsx # resources/js/Types/report.ts # routes/web.php
AmonDeShir
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* - Init (#1) * init * fix dockerfile * fix code style * - Fix taskfile * #8 - Auth (#32) * change vue to react * wip * auth * fix code style * apply suggestions * add import * Apply suggestions from code review * - remove api (#36) * fix routes * remove api * #9 - Listing Creation (#37) * 9 - Listing Creation * - Listing Creation * - task fix * - Copilot fixes * - task fix * - routes fix * - cr fixes * - cr fix 2 * - cr fix 3 * - cr fixes final final final (56) * - cr fixes final final final final final * - 3am mental asylum * - copilot slop * - cr fix final final final complete final * #4 - Edit Listing (#38) Added actions, controllers, requests and routes for: - Editing Auction. - Updating Auction. Added a policy for updating auction (user must be auction owner). Fixed auction description data type. * - Implement components (#39) * Implement components * fix code style * implement copilot suggestions * implement copilot suggestions * fix code style * #17 - Login page frontend (#40) * Implement components * fix code style * implement copilot suggestions * implement copilot suggestions * fix code style * Create navbar * Login page * Login page * Register * Reset Password * Fix register link * Fix CSRF * fix code style * Implement auctions page * fix code style * fix web * #16 - Create Listing Page - Frontend (#41) * Implement components * fix code style * implement copilot suggestions * implement copilot suggestions * fix code style * Create navbar * Login page * Login page * Register * Reset Password * Fix register link * Fix CSRF * fix code style * Implement auctions page * Added actions, controllers, requests and routes for: - Editing Auction. - Updating Auction. Added a policy for updating auction (user must be auction owner). Fixed auction description data type. * Implement auctions page * fix type * fix code style * fix linter * merge --------- Co-authored-by: DawBaz15 <[email protected]> * #7 - User Roles Management - Backend (#43) * #13 - Close Listing (#42) - Created endpoints for finishing and cancelling an auction. - Restored the update function in AuctionController. - Fixed route * #5 - Report Listing (#44) * 5 - Report Listing * cr changes and report resolved endpoint * #6 - listing image uploads backend (#45) * assing role on user register * add images to auctions * apply suggestions from copilot c: --------- Co-authored-by: Dawid Bazylewicz <[email protected]> * - Add auction view (#46) * wip * fix show page * fix code style * fix seeder * fix code style * fix code style * #12 - admin panel endpoints backend (#47) * 5 - Report Listing * assing role on user register * add images to auctions * apply suggestions from copilot c: * wip - admin panel, statistics * change Otoszroto\ to App\ * fix user factory * auctions stats screen * reports screen in admin panel * remove reason in reports, add link to auction * add translations * add lang/pl * fix code style --------- Co-authored-by: Dawid Bazylewicz <[email protected]> --------- Co-authored-by: DawBaz15 <[email protected]> Co-authored-by: Dominik Purgał <[email protected]> Co-authored-by: Dawid Bazylewicz <[email protected]>
No description provided.