Skip to content

Conversation

@Adlanehichembr
Copy link
Contributor

Proposed change

Type of change

  • Example (a notebook demonstrating how to use ZOSPy for a specific application)
  • Bugfix (non-breaking change which fixes an issue)
  • New analysis (a wrapper around an OpticStudio analysis)
  • New feature (other than an analysis)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • Documentation (improvement of either the docstrings or the documentation website)

Additional information

  • OpticStudio version: ...

Related issues

Checklist

  • I have followed the contribution guidelines
  • The code has been linted, formatted and tested (see the contribution guidelines).
  • Local tests pass. Please fix any problems before opening a PR. If this is not possible, specify what doesn't work and why you can't fix it.
  • I tested ZOSPy for all supported Python versions (hatch test -a).
  • I added new tests for any features contributed, or updated existing tests.
  • I updated CHANGELOG.md with my changes (except for refactorings and changes in the documentation).

If you updated an example:

  • I executed all examples and verified that they run without errors (hatch run all-examples).

If you contributed an example:

  • I contributed my example as a Jupyter notebook.

Copilot AI review requested due to automatic review settings December 10, 2025 13:19
jwmbeenakker
jwmbeenakker previously approved these changes Dec 10, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a spelling error in the README.md file where "fucntions" was misspelled and has been corrected to "functions".

Key Changes

  • Corrected spelling of "functions" in the README.md introduction section

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@crnh crnh dismissed jwmbeenakker’s stale review December 10, 2025 13:32

Was approved by accident

Copy link
Member

@jwmbeenakker jwmbeenakker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for spotting this typo. Out of curiosity, what kind of optical simulations do you aim to do with ZOSPy?

@jwmbeenakker jwmbeenakker merged commit f5a18ee into MREYE-LUMC:main Dec 10, 2025
7 of 8 checks passed
@crnh crnh added the skip changelog It is not necessary to update the changelog for this PR label Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changelog It is not necessary to update the changelog for this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants