Open
Conversation
added 8 commits
October 21, 2016 12:14
- in HttpConnection class doGet method now throws IOException if there is problem with internet connection and StatusException if there si some problem other then internet connection. StatusException class contains method getHttpStatusCode() that returns http status code for more detals about problem. This offers more detals about communicaiton problems. This caused that all request methods that uses HttpConnection.doGet() had to throw this exceptions. - in GeocoderNominatim class method buildAndroidAddress supported new tags from OSM. Setting of street address using tag "road" have added fallbacks to values with tags: "pedestrian", "footway", "cycleway", "bridleway", "highway", "address26". Tag "county" has set fallback value to tag "departement". Tag "state" has set fallback value to tag "region". Tag "house_number" set now in Address object with setSubThoroughfare() (since in documentations says: "This may correspond to the street number of the address") among others that are set mostly in Address extras Bundle. It is useful to have more address details espectialy in some countries where different tags are used. Some of tags added in Address extras if they exsist in response: "place_id", "type", "licence", "city", "town", "village", "subway", "golf_course", "bus_stop", "parking", "house", "building", "city_district", "pedestrian", "footway", "highway", "sub-city", "locality", "isolated_dwelling", "cycleway", "hamlet", "region", "departement", "neighbourhood", "residential".
- warnings fixes (improvements made)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I made some changes that i find useful to have. Often It is useful to know what problem happened in request that is made. Like if want to make route request and currently there is no internet connection or server is not reachable so user can be properly informed about problem. second change is more detailed Address info returned in geocoding/reversegeocoding.
So changes are:
Tag "house_number" set now in Address object with setSubThoroughfare() (since in documentations says: "This may correspond to the street number of the address") among others that are set mostly in Address extras Bundle. It is useful to have more address details espectialy in some countries where different tags are used. Some of tags added in Address extras if they exsist in response: "place_id", "type", "licence", "city", "town", "village", "subway", "golf_course", "bus_stop", "parking", "house", "building", "city_district", "pedestrian", "footway", "highway", "sub-city", "locality", "isolated_dwelling", "cycleway", "hamlet", "region", "departement", "neighbourhood", "residential".