Repository navigation
Add Proofpoint ET Intelligence expansion module - #989
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 19b7309f40
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enrich domains, IPv4 addresses and MD5 hashes using Proofpoint ET Intelligence.
Uses the v1 API with Authorization header authentication. IP and domain queries return reputation plus passive DNS pivots; MD5 queries return sample details. IPv6 is rejected before querying because the service contract is IPv4. max_results defaults to 25 (1-100). Reputation scores are retained as context, including score zero, and do not change source IDS flags.
Review updates: Maps the documented file_size field to the structured file size-in-bytes relation, retaining zero-byte values.
Configuration and example requests are documented in
documentation/expansion/proofpoint_et_intelligence.md. The source attribute and UUID are preserved, enrichment objects reference the source, and new attributes useto_ids=false.Validation:
30 passed, 1 warning in 0.91sfrompytest tests/test_proofpoint_et_intelligence.py, plus Black, isort, flake8 and whitespace checks. Provider responses are mocked; authenticated live API calls have not been exercised.