Repository navigation
fix: update HTTP dependencies for emSign and Brotli vulnerabilities - #969
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1eda738f8a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main package and website lockfiles contain outdated HTTP and CA dependencies. Add security minimums to both manifests and regenerate their lockfiles so both locked deployments and fresh package installs receive patched versions.
certifi removes the compromised emSign ECC root. The minimum follows Python's eMudhra incident guidance, which recommends 2026.10.19 for compatibility with unaffected roots.
Explicitly require a patched interpreter-specific Brotli decoder for CVE-2026-111497, including brotlicffi. Updating urllib3 alone does not patch the native decoder. urllib3 2.8.0 also includes the streaming decompression and subsequent HTTP/proxy security fixes.
Keep Tornado on the patched 6.5 series to preserve Python 3.10 support: Tornado 6.6 requires Python 3.11. The 6.5.10 release includes September's security fixes and the follow-up compatibility fix.
The website's old lock covered Python <3.13 while its manifest declares <4.0. Regeneration aligns that range and updates its misp-modules dependency from 3.0.2 to 3.1.0 with the related dependencies required by that resolution. The main lock retains all unrelated package versions.
Validation on Python 3.12:
poetry check --lock, wheel/sdist builds, and requirements exports succeed for both projects.pytest tests --ignore=tests/test_expansions.py -q --tb=short: 3,421 passed, 42 skipped; 13 subtests passed. The external-service expansion suite was excluded.pip checkpasses; the running service returns HTTP 200 from/healthcheck.emSign ECC Root CA - G3.Deployment: update existing environments or rebuild images from the new lockfiles. System CA stores and packaging tools with vendored certificate bundles also need the updates described in Python's incident guidance.