Repository navigation
Add OWASP CRS export for IDS-marked HTTP indicators - #966
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
owasp_crs_exportto generate custom ModSecurity phase 1 deny rules for use alongside OWASP CRS. The exporter includes only attributes with an explicitly enabledto_idsflag and excludes deleted data, without changing the input flags.Supports source IPs/CIDRs and source IP/port pairs, domains, hostnames and hostname/port pairs, HTTP(S) URLs, origin-form URIs, and user agents from event and object attributes. Composite conditions remain constrained, literals are validated and escaped, rules are deduplicated, and configurable IDs stay in the local 10000–99999 range. The module returns a base64-encoded
.conffragment, skipped counts and integration warnings.The usage guide documents proxy visibility, client address handling, exact URL matching, scheme limitations for origin-form requests, TLS inspection, direct denial versus CRS anomaly scoring, and ID reservation. Resolved destination IP indicators are excluded because
SERVER_ADDRdoes not reliably identify a proxy's upstream destination.Validation: