Repository navigation
Fix CEF export serialization and standard compliance - #963
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CEF exporter could produce malformed records from ordinary URL query strings, backslashes, pipes in device settings, and CR/LF in attribute values. It also emitted IPv6 in CEF:0 address fields and prepended a fabricated syslog host to file output.
This change aligns file serialization with the OpenText ArcSight CEF Implementation Standard, version 27, covering header definitions, file output, character encoding and the extension dictionary.
request=https://example.org/?a\=1.CEF:. Preserve attribute timestamps as epoch milliseconds in labeleddeviceCustomDate1fields, avoiding year loss, locale/timezone dependence, and assumptions that modification time is incident time.CEF:1for IPv6 address records while retainingCEF:0for other records.cat.text/plain.The usage guide documents configuration, mappings, an example, and migration implications. Collectors expecting the old syslog prefix, category-based event-class IDs, or only CEF:0 require corresponding updates. All supplied supported attributes remain included regardless of
to_ids; unsupported types remain ignored.Validation:
.venv/bin/python -m pytest -q tests/test_cef_export.py: 92 passed, including independent decoding/escaping checks, field limits, invalid-input handling, IPv4/IPv6, timestamps, event shapes and HTTP discovery/export.git diff --checkpassed.