Repository navigation
Migrate APIVoid expansion module to API v2 - #953
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The APIVoid expansion module still uses deprecated v1 GET endpoints, query-string authentication and v1 response schemas. APIVoid may remove v1 endpoints at any time from 1 November 2026: https://docs.apivoid.com/migrate-to-v2/
Migrate DNS, SSL and email verification to the v2 POST endpoints with JSON bodies and X-API-Key authentication. Parse grouped DNS records and root-level email/certificate responses; support AAAA records and both SHA-1 and SHA-256 fingerprints. Preserve object references and successful DNS results if the SSL request fails, annotating the original attribute with the failure.
Remove the obsolete stats requests and fractional credit checks so the API enforces quota and overage settings. Update module metadata and generated documentation, remove the duplicate suspicious_email attribute, and handle HTTP errors, rate limits, timeouts, invalid JSON and malformed responses as MISP errors. Requests are not automatically retried, so a hover does not wait through a retry/backoff cycle.
Migration: keep the apikey configuration name, but replace its value with an API key from https://dash.apivoid.com/. Each successful API call costs 1 credit: domain/hostname enrichment uses 2 calls and email verification uses 1.
Validation: 46 mocked regression tests pass, including the existing expansion smoke test contract, prepared HTTP request headers/body, MISP object values/references and error handling. Black and isort checks pass for the module and new tests; flake8 passes for the module; git diff --check passes. No live authenticated API calls were made.