Repository navigation
Add QRadar reference-set export and publishing action - #948
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add two modules for moving MISP indicators into IBM QRadar reference sets:
qradar_reference_set_exportexports one selected indicator type as a deduplicated, headerless CSV for Reference Set Management or a JSON array for tooling. It requires no QRadar connection. Counts and MISP provenance remain outside the import file.qradar_reference_set_publishis a blocking workflow action that adds or refreshes IDS-marked values in an existing reference set and explicit domain through the current API 20.0reference_data_collectionsendpoints. Its distinct name allows both modules to coexist in the server's module registry.A shared, network-free converter handles standard/bare/legacy event envelopes and object attributes. It supports IPv4, IPv6, domains/hostnames, URLs, MD5, SHA-1, SHA-256, SHA-512 and supported composites, with validation, normalization, deduplication and source references. Deleted data is excluded; the offline export offers an explicit non-IDS override. Port-qualified indicators are skipped so their constraints are not silently discarded.
Publishing behavior
SEC/Versionheaders.SHARED. Domain 0 remains distinct from shared data;SHAREDis serialized as JSON null and verified in the acknowledgement.IP; IPv6 and case-sensitive URLs useALN; domains and hashes acceptALNorALNIC.The action accepts at most 100 unique selected values per invocation, uses 15-second request timeouts and checks a 240-second processing budget. No new dependencies or MISP object templates are required. Both modules include setup/API guides and generated catalog entries. The export advertises static CSV MIME/extension metadata; JSON downloads may need renaming.
API contracts were checked against IBM's IOC import instructions, set metadata API, and entry creation/update API.
Validation
pytest -q tests/test_qradar_reference_set.py tests/test_sentinelone_ioc_publish.py tests/test_crowdstrike_ioc_publish.py tests/test_elastic_ecs_export.py tests/test_splunk_export.py: 529 passed, with one pre-existing Python deprecation warning.git diff --checkpasses.