Repository navigation
Bump whisper-misp to 0.0.2, default to graph.whisper.online, backfill attribute uuids - #932
Merged
Merged
Conversation
whisper-misp 0.0.2 identifies the client to the Whisper graph API (User-Agent: whisper-misp/<version>, X-Whisper-Client, X-Whisper-Client-Version) and sends bound query values under "parameters", the key the API binds, instead of "params". The module's moduleinfo version moves with the package. Fixes MISP#930 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…te uuids The Whisper graph API moved to its own front door, graph.whisper.online, on 2026-08-22; graph.whisper.security is being decommissioned. Installs that leave the api_url setting empty should reach the current host. A hand-crafted POST /query without an attribute uuid made the converter reference objects against a missing id; MISP itself always sends one. Backfill a uuid so direct API callers get well-formed object references. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #930
What
poetry.lock:whisper-misp0.0.1 -> 0.0.2. The unpinnedwhisper-mispentries in theminimalandallextras ofpyproject.tomlare unchanged.misp_modules/modules/expansion/whisper.py:moduleinfo["version"]0.0.1 -> 0.0.2, so the module reports the package version it runs with.DEFAULT_API_URLmoves fromhttps://graph.whisper.securitytohttps://graph.whisper.online, the Whisper graph API's own front door since 2026-08-22. Installs that leave theapi_urlmodule setting empty reach the current host; an explicitapi_urlis still honoured as before.handler()backfills an attributeuuidwhen a directPOST /queryomits one. MISP always sends the uuid, and the module'smisp_standardoutput references its objects against it, so hand-crafted calls without one produced object references to a missing id.Why
whisper-misp 0.0.1 sends every request to the Whisper graph API as
python-requests/<version>and posts bound query values underparams, a key the API ignores (it bindsparameters). 0.0.2 identifies the client (User-Agent: whisper-misp/<version>,X-Whisper-Client: whisper-misp,X-Whisper-Client-Version: <version>, the version read from the installed package metadata) and sends values underparameters. Value inlining and everything the module returns to MISP are unchanged, so analysts see no difference; operators who allow-list egress by User-Agent can now single out MISP. The default host and the uuid backfill bring the in-tree module file level with the maintained module.Testing
poetry update whisper-misp --lockresolves andpoetry check --lockpasses with the bumped entry; the module file is formatted with this repository's black and isort settings andflake8with its configuration is clean./modulesregistration check, and your pytest suite on Python 3.10 and 3.14.enrichEventforip-src,domainandASseeds, plus the hover endpoint): every request the module sent carried the new headers and theparameterskey, and the enrichment results ingested as before; a direct/querywithout a uuid returns objects whose references resolve.🤖 Generated with Claude Code