Repository navigation
Add URL DNS expansion with IP-port and IPv4 ASN objects - #929
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8b195de05a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
url_dns, a URL expansion module that resolves all A and AAAA answers into TCPip-portobjects and enriches public unicast IPv4 addresses with origin ASN objects through Team Cymru DNS TXT queries.An explicit URL port takes precedence; HTTP defaults to 80, HTTPS to 443, and other schemes require an explicit port. Each endpoint references the original URL attribute UUID with
derived-fromand its ASN objects withbelongs-to. ASN objects also reference the original URL withrelated-to. Shared ASNs and addresses are deduplicated within each expansion.The module supports IDNA hostnames, IPv4 and bracketed IPv6 literals, multi-origin prefixes, and an optional DNS nameserver. Non-global and multicast IPv4 addresses retain their endpoints without ASN queries. Partial DNS or ASN failures preserve successful endpoint results with explanatory comments. Generated attributes use
to_ids=false. No API keys, custom object templates, or additional repository dependencies are required.Includes module documentation, installation instructions, an example request, and 63 focused module tests.
Validation
python -m pytest -q tests/test_url_dns.py tests/test_rdap.py: 69 passed (63 module tests and 6 existing RDAP tests).DNS responses were mocked; live DNS and deployment to a running MISP instance have not been tested. IPv6 ASN enrichment is outside this module's scope.