Repository navigation
Add extended outbound HTTP debugging - #924
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1561a8cddf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The server's existing debug logs show module queries but do not show the HTTP exchanges between modules and their services. Add
--debug-extendedto enable normal debugging plus outbound HTTP request and response tracing:Log methods, URLs, headers, status codes, and untruncated bodies, with a unique exchange ID and the module name for concurrent queries. Trace streamed uploads and responses as they are sent or read, preserving lazy reads, binary data, compression, redirects, and exception behavior. Add usage and coverage details to the README and installation documentation.
Preserve buffer-protocol upload bodies such as arrays, passing the original object to the HTTP adapter and logging its bytes. Log the contents of streamed buffer chunks as well. WhoisFreaks copies the current context into each parallel domain and IP lookup so nested worker requests retain their module attribution.
Coverage includes
requestsand SDKs using its standard HTTP adapter. Other HTTP clients and adapters that replaceHTTPAdapter.sendare not covered; unread streamed response data is not logged. Custom modules starting their own worker threads must propagate the current Python context to retain module attribution. Extended mode deliberately includes credentials and sensitive payloads without redaction, with a startup warning and documentation explaining this behavior. HTTP tracing stays disabled for normal--debug.Validation:
--test --debug-extended --port 0.