Repository navigation
Fix MODAT host validation with anycast and classification tags - #923
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MODAT host responses include
is_anycastand classification tags. The module emitted a separateip-port.textattribute for each, but the standard template allows only one. A host withis_anycast=falseandtags=["Cloud"]therefore failed withUnable to process MODAT host data (InvalidMISPObject)and produced nothing to import.Combine anycast and classification notes into one text attribute, preserving all notes and the original JSON evidence. Also report the object name and failing template relation when object validation fails; diagnostics contain only template constraints, not attribute values or exception contents.
Follow-up to the merged #922. Add regression cases for anycast plus tags and multiple tags without anycast, expand the pinned-schema test with complete host metadata, and check that validation diagnostics identify repeated/missing relations without leaking data.
Validation: 90 offline tests passed. The three new host-note cases reproduced the reported warning before the fix. Black, isort, flake8 and
git diff --checkpassed. No object-template changes are required.