Repository navigation
Fix vulnerability_lookup defaults for unset MISP settings - #921
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MISP sends every advertised module setting, using
nullfor unset values. For example,config={timeout: "80", max_related: null, with_linked: null, ...}currently evaluatesint(None)and returns a validation error before making any API request. The module server returns that error as HTTP 200, explaining the observed 1.29 ms response with no enrichment.Treat null and blank settings as unset so numeric, boolean and CPE options use their documented defaults. Preserve explicit false/zero values and retain validation of invalid numeric settings. Document that the top-level request timeout limits total module execution independently of the per-API
config.timeout; MISP sends the former fromPlugin.Enrichment_timeout(or the hover setting).Validation: reproduced the original configuration with zero HTTP calls, then confirmed the exact logged payload reaches the lookup after the fix. All 66 focused tests pass, including null/blank defaults and explicit false/zero cases. Changed Python modules pass flake8 and
git diff --check. Confirmed CVE-2026-87902 exists in the live CIRCL API.Follow-up to the merged #920.