Repository navigation
Add MODAT Magnify infrastructure enrichment module - #919
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 40b79d0531
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a MODAT Magnify expansion module that turns infrastructure attributes into linked MISP host, service and historical DNS observations. For example, enriching
ip-dst|port=2001:db8::1|8443keeps both the address and port as query constraints, while enriching a domain also retrieves its DNS record history.The module supports 32 relevant input types, maps all 129 detailed-service leaf fields, and audits all 194 current PyMISP attribute types in coverage tables. Unsupported types are rejected rather than advertised as searchable. URL pivots use host/port, filename/hash pivots use the hash, and email pivots search certificate alternative names. The pinned API specification contains no WHOIS endpoints.
Reuse existing infrastructure templates and return the new
modat-serviceandmodat-dns-recordobservations proposed in MISP/misp-objects#539. Matching template copies are bundled so the module can generate objects before a PyMISP template release; installation instructions explain how to register them in MISP.Original JSON preserves nested arrays and future fields. Discovered attributes have
to_ids=false; shared objects are deduplicated within each response and linked to the queried attribute. Generated objects and host attachments retain fresh PyMISP UUIDs so identical evidence in separate enrichments cannot collide across events. Server JA3S/JA4 fingerprints retain their meaning, DNS deletion timestamps are not treated as last-seen, and CVEs describe inferred exposure. Search pagination is bounded, and HTTP/network errors are reported without exposing credentials or response bodies.Validation:
python -m pytest tests/test_modat.py -q: 80 passed. Tests cover every advertised input, all detailed-service fields against the pinned OpenAPI 1.65.2 contract, composite constraints, IPv6, pagination, error handling, object references, template schemas, DNS history, independent UUIDs across enrichments and deduplication within one response.git diff --checkpassed for the change.misp-objects' full./validate_all.shsuite, and the bundled definitions are identical.Live authenticated enrichment has not been tested because no MODAT API key was configured.