Skip to content

[medium] fix: [cof2misp] make strict COF validation actually check mandatory fields #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
elhoim wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[medium] fix: [cof2misp] make strict COF validation actually check mandatory fields #835

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion misp_modules/lib/cof2misp/cof.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def is_cof_valid_strict(d: dict) -> bool:
--------
True on success, False on validation failure.
"""
return True # FIXME
return is_cof_valid_simple(d) # FIXME: the full JSON Schema validation is still missing


def is_cof_valid_simple(d: dict) -> bool:
Expand Down