Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename everything to not use calc #182

Merged
merged 4 commits into from
Feb 8, 2025
Merged

Conversation

hmacdope
Copy link
Member

@hmacdope hmacdope commented Jan 2, 2025

Rename calc_bonds to calc_distances, more correct name

@richardjgowers should we keep the Calc prefix? Now is the time to remove even if labour intensive

@pep8speaks
Copy link

Hello @hmacdope! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 33:80: E501 line too long (83 > 79 characters)
Line 61:80: E501 line too long (82 > 79 characters)
Line 66:80: E501 line too long (86 > 79 characters)
Line 86:80: E501 line too long (89 > 79 characters)
Line 95:80: E501 line too long (93 > 79 characters)
Line 104:80: E501 line too long (97 > 79 characters)
Line 375:80: E501 line too long (87 > 79 characters)
Line 378:80: E501 line too long (96 > 79 characters)
Line 380:80: E501 line too long (100 > 79 characters)
Line 397:80: E501 line too long (108 > 79 characters)

@richardjgowers
Copy link
Member

@hmacdope yeah I'm not wildly in love with calc_bonds as a name, but calc_distances is perhaps more vague, most the functions are calculating a distance of some sort. How about zip_distances? the logic being it's a bit like distance(a,b) for a, b in zip(c1, c2)

@richardjgowers
Copy link
Member

also yeah calc_ everywhere is tiresome

@hmacdope hmacdope changed the title rename calc_bonds rename everything to not use calc Feb 8, 2025
@hmacdope
Copy link
Member Author

hmacdope commented Feb 8, 2025

@richardjgowers I have removed Calc from everywhere, but I haven't gone through and added Zip to the relevant ones. Would it be so bad to go ahead without it?

@richardjgowers
Copy link
Member

@hmacdope Sounds good!

@richardjgowers richardjgowers merged commit 54f739a into MDAnalysis:main Feb 8, 2025
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants