feat : GA4 trackedpage 추가 및 click 이벤트 할당 (정준영 part)#219
Merged
Conversation
junjeeong
changed the title
junjeeong
changed the title
junjeeong
changed the title
Collaborator
|
전반적으로 기획된 내용과 작성하신 내용이 일치하지 않는 것 같습니다! 전에 회의때 지운님이 말씀하신 것처럼 노션의 매개변수(page, element)값으로 태깅을 해주셔야 합니다. 추가적으로, 전에 요청드렸던 것처럼 노션의 상태값 업데이트도 부탁드립니다. |
Soohyuniii
reviewed
Apr 24, 2025
src/App.tsx
Outdated
| { path: "/mbti-result", page: "Mbti 테스트 결과" }, | ||
| { path: "/chat-recommend", page: "대화 주제 추천" }, | ||
| { path: "/chat-tips", page: "대화 꿀팁" }, | ||
| { path: "/chat-temporature", page: "대화 온도 측정" } |
Collaborator
There was a problem hiding this comment.
여기를 포함해서 page 값이 지운님이 설정해주신 값들과 다른 것 같은데 혹시 따로 업데이트 된 사항일까요?
Collaborator
Author
There was a problem hiding this comment.
흠... 제가 이해를 잘못했네요! 설정해주신대로 다시 수정하겠습니다!
Collaborator
Author
|
0f7c186 |
Collaborator
|
제가 리뷰드린 부분들 뿐만 아니라, 이전에 코멘트 달았던 것과 같이 전반적으로 확인해서 수정 부탁드립니다. |
Soohyuniii
reviewed
Apr 25, 2025
src/components/Profile.tsx
Outdated
| }; | ||
|
|
||
| const handleNavigate = () => { | ||
| trackClickEvent("홈", "친구 - 대화 시작하기 버튼"); |
Collaborator
There was a problem hiding this comment.
이부분도 홈, 친구 - 바로 대화하기 인데 다른 것 같습니다.
| navigate("/mbti-test"); | ||
| } | ||
| const goFirstStep = () => { | ||
| trackClickEvent("/MBTI 테스트 결과", "돌아가기 버튼"); |
Collaborator
There was a problem hiding this comment.
돌아가기 버튼이라는 element도 존재하지 않는 element인 것 같습니다.
Collaborator
Author
|
notion에 있는 것과 모두 동일한지 확인했고, 기존에 작성한 것중에 기획과 다른 것도 모두 삭제했습니다! |
Soohyuniii
approved these changes
Apr 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull requests
✅ 작업한 내용
🔢 #216
❗️PR Point
📸 스크린샷