GH-605: Review two #704

utkarshg6 · 2025-09-12T14:01:46Z

Note

Replace fingerprint-based pending-payables with sent/failed tx tracking and new receipt/status types; refactor scanners/scheduling, adjust blockchain receipt API, compute chain-based defaults, and drop the pending_payable table.

Accountant/Scanners:
- Introduce DetailedScanType; replace ReportTransactionReceipts with TxReceiptsMessage and PendingPayableFingerprintSeeds with RegisterNewPendingPayables.
- Revamp PendingPayableScanner with in-memory caches, recheck logic, and distinct handling for confirmations/reclaims/validation failures.
- Rename ScanRescheduleAfterEarlyStop → ScanReschedulingAfterEarlyStop; refine retry/reschedule behavior.
- Switch amount/gas fields to amount_minor/gas_price_minor; update comparisons and logs.
Blockchain:
- process_transaction_receipts now returns a map keyed by TxHashByTable to TxReceiptResult using StatusReadFromReceiptCheck.
- Update send flow and logs; minor wording tweak (gas price “computed by this Node”).
Data structures/Errors:
- Add TxHashByTable, StatusReadFromReceiptCheck, TxBlock; rework TxStatus/FailureStatus with ValidationStatus and PreviousAttempts (serde support).
- Refine RPC/Blockchain error kinds (split local/remote) and display.
DB/Migrations:
- Compute default ScanIntervals per-chain; migrate scan_intervals accordingly.
- Remove pending_payable table (migration 10→11); adjust schema and DAO usage.
Config/Validation:
- Validate scan-intervals relationship and payment-thresholds; expose neighborhood/rate/scan settings.
Tests/Utils:
- Extensive test updates; add serializer mocks, receipt builders, and helper utilities.

^{Written by Cursor Bugbot for commit 02d98fb. This will update automatically on new commits. Configure here.}

* GH-598-json-hotfix: corrected * GH-598-json-hotfix: little fix * GH-598-json-hotfix: rearrangement * GH-598-json-hotfix: addressing the review * GH-598-json-hotfix: finished addressing review --------- Co-authored-by: Bert <[email protected]>

node/src/accountant/scanners/payable_scanner/mod.rs

node/src/accountant/db_access_objects/sent_payable_dao.rs

node/src/accountant/scanners/payable_scanner/tx_templates/priced/new.rs

bertllll · 2025-09-12T14:55:28Z

node/src/blockchain/blockchain_interface/blockchain_interface_web3/utils.rs

-            hashes_and_balances: hashes_and_paid_amounts,
-        })
-        .expect("Accountant is dead");
+    // TODO: GH-701: We were sending a message here to register txs at an initial stage (refer commit - 2fd4bcc72)


Why couldn't you also just comment it out instead of deleting the good inspiration for the person who will be fixing this.

I've added the commit hash.

node/src/blockchain/blockchain_interface/blockchain_interface_web3/utils.rs

* GH-642: interim commit * GH-642: interim commit * GH-642: interim commit * GH-642: big initial messy reconstruction continuing... * GH-642: big initial messy reconstruction... just realized I may've forgotten to update with the last changes from the other card * GH-642: tests compiling...failing lots of them * GH-642: fn confirm_transactions has been reimplemented * GH-642: fn handle_failed_transactions has been reimplemented * GH-642: fixed mainly internal, but smaller functions in the pending payable scanner; various From and Display implementations and these sorts * GH-642: progressed quite greatelly; fixed many tests; took action against the mark pending payable rowid fn * GH-642: another bunch fixed...down to 24 * GH-642: another bunch fixed...down to 10 * GH-642: the base of this card is done * GH-642: lots of fixes in names * GH-642: filling cache with failed txs to recheck at startup * GH-642: rpc failers during receipt checks can be handled now * GH-642: interim commit * GH-642: first I need to finish the impl of the db system of tx statuses...opened in its own PR and then will start from here on * GH-642: pending payable scanner machinery has been given the true skeleton * GH-642: before creating a new whole folder for scanner utils * GH-642: interim commit * GH-642: preparing tests before writing the guts of the core fns * GH-642: integration of the caches...100% at start_scan, 90% finish_scan * GH-642: another big portion of work in interpreting the receipts * GH-642: finishing tests for the receipt interpretation but I should rearrange the code a bit - maybe to add a separative class * GH-642: mod structure changed, new file for TxReceiptInterpreter * GH-642: fixed two unreliable tests * GH-642: interim commit * GH-642: worked away on the implementation of handling failed txs * GH-642: more todos!() gone * GH-642: processing failures is done; next tx confiramtions * GH-642: tx reclaim implemented * GH-642: finished the brain functions in PPS * GH-642: ValidationStatus extension - huge chunk of work; still some failing tests remain * GH-642: interim commit (some of the Validation error stuff will have to be fixed) * GH-683: savepoint * GH-683: interim commit * GH-683: mostly done * GH-683: renamed error * GH-683: additional fix to renaming * GH-683: finished * GH-642: finished * GH-683: fixed for a review * GH-683: fixed screwed string replacement * GH-683: finished fixing it * GH-683: another fix...BlockchainError * GH-642: added unreachable! * GH-642: before bigger issue addressing * GH-642: got rid of the BlockchainFailure::Unrecognized layer * GH-642: savepoint * GH-642: hashmap for receipt status result deployed * GH-642: finally solid... as much as under this card, tests fixed * GH-598-json-hotfix: interim commit * GH-642: dragging the failing tests down to bare minimum * GH-642: interim commit * GH-642: before fixing the todo!() left over * GH-642: finished * GH-642: cosmetics * GH-642: grrr - cosmetics - forgot e * GH-642: review 2 addressed * GH-642: added the cache clean-up on getting a scan error --------- Co-authored-by: Bert <[email protected]>

* GH-689: finished * GH-689: fixes after auto-review --------- Co-authored-by: Bert <[email protected]>

* GH-606-v2: db and help msgs + the interface document * GH-606-v2: constraint/raletion between scan intervals established * GH-606: final clean-up * GH-606-v2: after review * GH-606-v2: formatting --------- Co-authored-by: Bert <[email protected]>

…r PartialOrd and Ord

utkarshg6 and others added 15 commits August 24, 2025 18:21

GH-605: pre review changes

928d136

GH-598-json-hotfix (#699)

24e0a8a

* GH-598-json-hotfix: corrected * GH-598-json-hotfix: little fix * GH-598-json-hotfix: rearrangement * GH-598-json-hotfix: addressing the review * GH-598-json-hotfix: finished addressing review --------- Co-authored-by: Bert <[email protected]>

GH-605: review changes

093d7de

GH-605: eliminate new_fingerprints_recipient

2fd4bcc

GH-605: add commit hash to TODO

44be81d

GH-605: add TODOs for GH-703

cc7da7a

GH-605: refactor out the failed_tx

d666e53

GH-605: more review changes

2450508

GH-605: more refactoring of sql values

bb1a67d

GH-605: further fixes

074a40b

GH-605: more changes

070123a

GH-605: change it to retrieved_payables

52034fb

GH-605: rename to determine_next_scan_to_run

8f63153

GH-605: more changes

1c2d773

GH-605: improve the TODO

e851f34

bertllll changed the title ~~GH-605: Review 1~~ GH-605: Review two Sep 12, 2025

bertllll reviewed Sep 12, 2025

View reviewed changes

node/src/accountant/scanners/payable_scanner/mod.rs Show resolved Hide resolved

bertllll reviewed Sep 12, 2025

View reviewed changes

node/src/accountant/db_access_objects/sent_payable_dao.rs Show resolved Hide resolved

bertllll reviewed Sep 12, 2025

View reviewed changes

node/src/accountant/scanners/payable_scanner/tx_templates/priced/new.rs Show resolved Hide resolved

bertllll reviewed Sep 12, 2025

View reviewed changes

node/src/blockchain/blockchain_interface/blockchain_interface_web3/utils.rs Show resolved Hide resolved

bertllll and others added 3 commits September 15, 2025 10:15

GH-689: Amend scanner scheduling: Handling ScanError msg (#691)

6e020c7

* GH-689: finished * GH-689: fixes after auto-review --------- Co-authored-by: Bert <[email protected]>

GH-605: add TODO for the test

24396b1

This comment was marked as outdated.

Sign in to view

bertllll and others added 5 commits September 16, 2025 13:11

GH-605: more and more changes

d2fd9cd

GH-605: bit more refactoring

52411c9

GH-605: bit more changes

398bdd9

GH-605: changing to & works

e044dc4

utkarshg6 added 4 commits September 22, 2025 13:00

GH-605: Review 4

73395d8

GH-605: Bug bot error

7522708

GH-605: Just merged; 567 errors

e7c7716

GH-605: reduced errors to 97

794d23a

This comment was marked as outdated.

Sign in to view

utkarshg6 added 4 commits September 24, 2025 19:42

GH-605: only 37 errors remaining

655830d

GH-605: only 5 errors remaining

06106f7

GH-605: only 2 errors remaining

8947136

GH-605: all errors gone

b2df759

This comment was marked as outdated.

Sign in to view

utkarshg6 added 2 commits September 25, 2025 18:57

GH-605: tests in sent_payable_dao are passing

2828f80

GH-605: all tests pass in payable scanner

9a51af4

This comment was marked as outdated.

Sign in to view

utkarshg6 and others added 9 commits September 26, 2025 09:46

GH-605: fix most of the clippy warnings

663c30e

GH-605: fix more of these problems

6c84f82

GH-605: write test for the ordering of ValidationStatus

2f07581

GH-605: implement ordering for ValidationStatus

d6b8592

GH-605: comment out unused code

5838a52

GH-605: more changes fixed

eab920d

GH-605: more fixing

2cbdffe

GH-605: interim commit

62f3542

GH-605: all tests in Node passing

97f54c8

This comment was marked as outdated.

Sign in to view

Bert added 7 commits September 28, 2025 11:31

GH-605: last todo removed

d94d5cb

GH-605: fixed poor test coverage

b82e3d2

GH-605: free of unnecessary boilerplate code - erased manual impls fo…

76a857c

…r PartialOrd and Ord

GH-605: continuous impovement -- Ord and little refactoring

b9ad935

GH-605: CI except MNT just fine

00f0223

GH-605: MNT fixed

15a4de1

GH-605: small correction

02d98fb

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

GH-605: Review two #704

GH-605: Review two #704

Uh oh!

utkarshg6 commented Sep 12, 2025 •

edited by cursor bot

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bertllll Sep 12, 2025

Uh oh!

utkarshg6 Sep 16, 2025

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

GH-605: Review two #704

Are you sure you want to change the base?

GH-605: Review two #704

Uh oh!

Conversation

utkarshg6 commented Sep 12, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bertllll Sep 12, 2025

Choose a reason for hiding this comment

Uh oh!

utkarshg6 Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

utkarshg6 commented Sep 12, 2025 •

edited by cursor bot

Loading