GH-623: Direct Node to pick new public key on the command line #679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnwiebe
commented
Aug 3, 2025
dnwiebe
commented
Aug 3, 2025
dnwiebe
commented
Aug 3, 2025
dnwiebe
commented
Aug 3, 2025
dnwiebe
commented
Aug 3, 2025
dnwiebe
commented
Aug 3, 2025
dnwiebe
commented
Aug 3, 2025
dnwiebe
commented
Aug 3, 2025
czarte
approved these changes
Aug 4, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| .expect("Failed to set cryptde"); | ||
| Ok(Some(main_cryptde)) | ||
| } | ||
| }; |
There was a problem hiding this comment.
Bug: Inconsistent Parsing of new-public-key Parameter
The new-public-key parameter is parsed inconsistently. Privileged parsing manually converts it from a string to Option<bool>, which is case-sensitive and conflicts with the argument's case_insensitive(true) definition, causing panics for valid inputs like "ON". Unprivileged parsing correctly uses the OnOff enum. The new_public_key_opt field set during privileged parsing is also unused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.