GH-552: Eliminate extra block increment #576
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertllll
reviewed
Jan 29, 2025
| let to = "0x3f69f9efd4f2592fd70be8c32ecd9dce71c472fc"; | ||
| let port = find_free_port(); | ||
| #[rustfmt::skip] | ||
| let _test_server = TestServer::start (port, vec
There was a problem hiding this comment.
This, the use of this TestServer isn't an issue immediately. However, when Syther and Utkarsh completes their work on GH-744, there might not be this thing anymore in the codebase. I've acquired an impression that they go with its alternative only, the MockBlockchainClientServer.
This might surprise you unpleasantly, therefore I'm preparing you for that eventuality. At least after this you could possibly recall I've mentioned it once and it'll bring you there to what you need.
node/src/blockchain/blockchain_interface/blockchain_interface_web3/mod.rs
Show resolved
Hide resolved
node/src/blockchain/blockchain_interface/blockchain_interface_web3/mod.rs
Outdated
Show resolved
Hide resolved
node/src/blockchain/blockchain_interface/blockchain_interface_web3/mod.rs
Outdated
Show resolved
Hide resolved
node/src/blockchain/blockchain_interface/blockchain_interface_web3/mod.rs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to the original GH-552 with a new branch of the same name.
max_block_countsize chunks and doesn't skip any blocks by incrementing one too many times.