forked from E3SM-Project/E3SM
-
Notifications
You must be signed in to change notification settings - Fork 4
Add flux-corrected transport scheme to MALI #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
matthewhoffman
merged 46 commits into
MALI-Dev:develop
from
trhille:add_higher_order_advection
Sep 6, 2023
Merged
Changes from all commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
119cfd9
Add calls to higher order advection scheme
trhille 7532330
Copy higher-order ocean advection routines
trhille aac672a
Update Makefile to include fct modules
trhille 47d6154
Initialize fct from tracer_setup
trhille 5dd26c6
Add li_mesh module
trhille e549c55
Comment out irrelevant parameters and routine in li_mesh
trhille f97dd56
Add li_config module
trhille ab8ec14
Add fct variables to Registry
trhille 494d092
Remove ocean variables from li_advection_fct and li_advection_fct_shared
trhille d9f9317
Update shared Makefile to include li_config
trhille 9518f49
Fix call to li_advection_fct_tend
trhille 30d387c
Fix typo in call to li_config
trhille 414eac6
Remove call to tracer_advection_vert_flx
trhille 83f5168
Clean up mesh variable definitions in li_mesh
trhille 79edb95
Fix public parameter allocations
trhille 3c42538
Clean up li_advection_fct_tend
trhille a364f7a
Add support for fo thickness with fct tracer advection
trhille e85d3fd
Apply tendencies to tracers with fct advection
trhille 6da1573
Pass layerThicknessOld to fct tracer advection routine
trhille 8734303
Add support for fct thickness advection
trhille 8d08525
Use cellMask_dynamicMargin to calculate advMaskHighOrder
trhille 36ea0a4
Use dynamic ice mask to define advMaskHighOrder
trhille 12981f5
Use boundaryCell to define advMaskHighOrder
trhille 2c66078
Update nTracers as tracers are added
trhille ab87706
Allocate arrays after nTracers has been calculated
trhille 0f66471
Pass array of 1s as dummy tracer for fct thickness advection
trhille 7e3d897
Fix bug in marking boundaryCell
trhille 0e6fbb9
Add passiveTracer to help verify advection schemes
trhille 697f7f9
Increase max number of tracers to accomodate passiveTracer
trhille dae96e7
Pass layerThickness as tracer instead of array of 1s
trhille 4c87809
Change normalThicknessFlux, layerThickness, and tracer definitions
trhille aa85232
Try new mask for 2nd order terms
trhille 70ec7bb
Make 2nd order and 3rd-4th order masks mutually exclusive
trhille 4104681
Clean up 2nd order mask
trhille 4f313f1
Call li_tracer_advection_fct_tend for thickness and tracers separately
trhille 5889ba6
Make fct conserve mass
trhille fd6792b
Fix first order flux at ice edge
trhille 8d2f023
Make conserve tracer volume
trhille 38f3f2b
Simple cleanup after code review
trhille 7cff4b7
Throw error forr fct thickness with fo tracer
trhille 9530ad5
Make activeTracerHorizontalAdvectionEdgeFlux optional
trhille aa2999a
Fix bug with activeTracerHorizontalAdvectionEdgeFlux
trhille 35a89ae
Fix the case of fo thickness, none tracer advection
trhille f43c26b
Only pass layer thickness tracer for first call to fct
trhille 8f218c3
Change passiveTracer to passiveTracer2d
trhille 52d9a0b
Enable fct thickness advection without tracer advection
trhille File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.