Skip to content

Hydro model channel improvements #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

Hydro model channel improvements #156

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
95450f3
Add option to disallow terrestrial outflow
matthewhoffman Oct 16, 2025
d51a403
Move assignment of melt input outside of SGH subcycling loop
matthewhoffman Oct 17, 2025
f20a97b
Add more timers to hydrology solve
matthewhoffman Oct 21, 2025
c2d4944
Prevent uphill outflow at terrestrial margins
matthewhoffman Oct 27, 2025
ece5ce1
disable channel melt into/out of lakes
matthewhoffman Nov 2, 2025
6cd0d58
Allow channel melt out of lakes but not into or within
matthewhoffman Nov 4, 2025
3cd22f7
Remove code that disables channel melt in lakes
matthewhoffman Nov 5, 2025
b6581ba
Disable iceThicknessHydro option by default
matthewhoffman Nov 5, 2025
30b2d3d
Add max channel area option
matthewhoffman Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions components/mpas-albany-landice/src/Registry_subglacial_hydro.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,8 @@
possible_values="positive real number"
/>

<nml_option name="config_SGH_use_iceThicknessHydro" type="logical" default_value=".true." units="unitless"
description="Option to use an altered ice thickness field called iceThicknessHydro that replaces local maxima/minima in upperSurface with a mean of the cells neighbors. This option has no significant effect on the behavior of the model but makes it more stable."
<nml_option name="config_SGH_use_iceThicknessHydro" type="logical" default_value=".false." units="unitless"
Copy link

@alexolinhager alexolinhager Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we will eventually need to port your MPAS-Tools ice surface alteration code into MALI if we want to run with evolving dynamics. The primary reason for iceThicknessHydro was the development if single-cell surface depressions that formed when running coupled simulations. This was mostly an issue when running with the higher order velocity solver, which created speckled ice thicknesses along the domain edges as the run progressed.

It seems like the MPAS-Tools code should fix that issue, so I think we should try replacing the iceThicknessHydro code with what you wrote there. Would it be better to make that it's own PR, or tack it onto this one?

description="Option to use an altered ice thickness field called iceThicknessHydro that replaces local maxima/minima in upperSurface with a mean of the cells neighbors. This option has no significant effect on the behavior of the model but makes it more stable. NOTE: Current implementation causes unrealistic bumps in thickness near the grounding line in many places, which prevents realistic outflow. Enable this option with care."
possible_values=".true. or .false."
/>

Expand Down